search

dynamicslab / hydrogym

An RL-Gym for Challenge Problems in Data-Driven Modeling and Control of Fluid Dynamics.
https://hydrogym.readthedocs.io
MIT License
48 stars 10 forks source link

Old Checkpoint files no longer compatible with new firedrake #106

Open SamAhnert opened 9 months ago

SamAhnert commented 9 months ago

I'd like to document that in moving away from pickle (see this commit), the firedrake team rendered data generated and checkpointed on the old version incompatible with the new version if I'm reading this thread correctly.

This renders our tutorial notebooks unusable with the new version of firedrake, and I think the easiest solution is to regenerate the data (especially since pickle is quite fickle with the way it ties itself to versions of packages etc.). I'n not sure how much of a priority we want this to be since it is an issue that would prevent any newcomers from being able to run our tutorials. Not necessarily a bug with the package itself, but this might deter folks interested in HydroGym unfortunately.

ludgerpaehler commented 9 months ago

Probably for the best if we regenerate the tutorials tbf (and expand them slightly..)

SamAhnert commented 9 months ago

I agree and we could include loading checkpoints for that (although maybe expanding/refactoring is a separate discussion?). I think that the checkpoints not working is an immediately pertinent issue that's worth addressing in the short-term. I can start running simulations to generate checkpoints.