The ParametrizedLibrary has a correction term when tensoring weak libraries. Does that code better belong in TensoredLibrary? If I use a TensoredLibrary for weak libraries without correction, would that create a nonsensical optimization problem?
More abstractly, I get the feeling the subclasses ParametrizedLibrary and GeneralizedLibrary largely exist in order to handle tensoring/concatting weak libraries where the TensoredLibrary doesn't handle weak form correctly. If so, and if that were corrected, would we be better without the extra classes?
The
ParametrizedLibraryhas a correction term when tensoring weak libraries. Does that code better belong inTensoredLibrary? If I use aTensoredLibraryfor weak libraries without correction, would that create a nonsensical optimization problem?More abstractly, I get the feeling the subclasses
ParametrizedLibraryandGeneralizedLibrarylargely exist in order to handle tensoring/concatting weak libraries where theTensoredLibrarydoesn't handle weak form correctly. If so, and if that were corrected, would we be better without the extra classes?