search

dynamicslab / pysindy

A package for the sparse identification of nonlinear dynamical systems from data
https://pysindy.readthedocs.io/en/latest/
Other
1.36k stars 304 forks source link

Pde feature library wrapper #449

Closed Jacob-Stevens-Haas closed 5 months ago

Jacob-Stevens-Haas commented 6 months ago

This is the part of #433 that's universally agreed upon, tabling the discussion about forward compatibility of research/example notebooks for now until we follow up on zoom.

I'm going to go ahead and review first, as I'll probably need to edit some stuff before it's ready.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (2633ee0) 93.87% compared to head (bf959d3) 93.87%. Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #449 +/- ## ========================================== - Coverage 93.87% 93.87% -0.01% ========================================== Files 37 37 Lines 3626 3592 -34 ========================================== - Hits 3404 3372 -32 + Misses 222 220 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Jacob-Stevens-Haas commented 6 months ago

Fails coverage because: +959 −1,455

The old code was verbose, so deleting it lowers coverage percentage. I.e. a pass in my book :)

Ready for review