Do we need `test_trapping_cubic_library()`?

dynamicslab / pysindy

A package for the sparse identification of nonlinear dynamical systems from data

https://pysindy.readthedocs.io/en/latest/

Other

1.36k stars 304 forks source link

Do we need `test_trapping_cubic_library()`? #453

Open Jacob-Stevens-Haas opened 6 months ago

Jacob-Stevens-Haas commented 6 months ago

AFAIK, we don't do trapping with a cubic library. The current test just verifies that it's possible to fit a SINDy model with a trapping optimizer and a custom library with the following functions?

    library_functions = [
        lambda x: x,
        lambda x, y: x * y,
        lambda x: x**2,
        lambda x, y, z: x * y * z,
        lambda x, y: x**2 * y,
        lambda x: x**3,
    ]