search

dynamicslab / pysindy

A package for the sparse identification of nonlinear dynamical systems from data
https://pysindy.readthedocs.io/en/latest/
Other
1.36k stars 304 forks source link

BUG(axes): Make concat out param work #454

Closed Jacob-Stevens-Haas closed 5 months ago

Jacob-Stevens-Haas commented 6 months ago

AxesArray.concatenate() failed whenever the out argument was set. (See docs).

This PR enables the full calling signature of concatenate with AxesArrays. It was discovered in some trapping work, as np.stack calls concatenate internally.

See the one added test, which fails on master branch and passes here.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (638e4bb) 93.87% compared to head (679b4dc) 93.91%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #454 +/- ## ========================================== + Coverage 93.87% 93.91% +0.03% ========================================== Files 37 37 Lines 3627 3630 +3 ========================================== + Hits 3405 3409 +4 + Misses 222 221 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.