search

dynamicslab / pysindy

A package for the sparse identification of nonlinear dynamical systems from data
https://pysindy.readthedocs.io/en/latest/
Other
1.46k stars 324 forks source link

Differentiation of Multidimensional Arrays in SINDyDerivative #476

Closed yb6599 closed 4 months ago

yb6599 commented 9 months ago

This PR addresses the issue and lets SINDyDerivative handle arrays with more dimensions than 2.

codecov[bot] commented 9 months ago

Codecov Report

Attention: Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.42%. Comparing base (024bc9e) to head (f4b8be7). Report is 11 commits behind head on master.

:exclamation: Current head f4b8be7 differs from pull request most recent head 30188e9

Please upload reports for the commit 30188e9 to get more accurate results.

Files Patch % Lines
pysindy/differentiation/sindy_derivative.py 92.30% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #476 +/- ## ========================================== - Coverage 94.68% 94.42% -0.27% ========================================== Files 38 38 Lines 4105 4069 -36 ========================================== - Hits 3887 3842 -45 - Misses 218 227 +9 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Jacob-Stevens-Haas commented 5 months ago

LGTM, but we'll wait to merge it until the derivative PR, since we'll probably have to set the requirements to 0.6.2