Closed Jacob-Stevens-Haas closed 2 months ago
Attention: Patch coverage is 95.79832%
with 5 lines
in your changes are missing coverage. Please review.
Project coverage is 94.68%. Comparing base (
80171b7
) to head (cb1ab37
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This is part 2/3, clarifying the way constraints are applied and allowing other constraints to be added to Trapping problems, by dispatching all to Constrainted SR3. It also solves some bugs in cvxpy
probs
. Part 3/3 will be the Mai's local trapping bit.Currently there is a small hack - constraints are added at initialization, but in order to add trapping constraints, we need to know the size of the problem, which are data-dependent parameters. Solution in the interim is to add arguments to init that begin with an underscore.