Remove html template tag from children

[Teods]

The problem solved with this PR is about the tag "template" who is parsed as an slide or an indicator when the library init the slider.

See issue https://github.com/dynamicweb/swiffy-slider/issues/46

[nicped]

Thanks for your pull. Would changing the selector to ‘*:not(template)’ template achieve the same?

[Teods]

I'm not sure about what part you are referring too.

• If we only change the CSS selector and not the javascript code (for me you need to change both because the javascript will parse the template object and this is not necessary in the slider case) ?
• Or do you want to apply the same logic for javascript (but for me the *:not(template) only work in CSS not in Javascript) ?

Maybe you could point me on the code directly thanks :-)

[nicped]

Sorry - i am only on my phone as i am on vacation :-). The changes you made in js - could also just use the change of selector like your css change - original code is this: sliderElement.querySelectorAll(".slider-container>*") Just change the selector to also include the :not(template) part. I am not fan of the iteration of children on the slider element in your 2 new methods, and the tolower as I see both as performance degrations (though barely measurable). Maybe the methods should be kept, but with css query selector instead - whatever is the smallest footprint kb wise. You can also leave the pr as is - and I will take a look when back.

[Teods]

Sorry i'm quite busy these days and on holiday for 2 weeks tonight. I'll try to make the changes as soon as possible when i get back from holiday.