dynamicweb / swiffy-slider

Super fast carousel and slider with touch for optimized websites running in modern browsers.
MIT License
250 stars 29 forks source link

show2 not working on mobile but works on Bigger devices #52

Closed charlesaloaye closed 2 years ago

charlesaloaye commented 2 years ago

The slider-item-show2 class not working on mobile but works on Bigger devices

nicped commented 2 years ago

Thank you for the report/question. The behavior is responsive by design so it collapses to one slide on devices smaller than 62rem@16px = 992px.

You can simply override it though - by setting the item count explicitly like this: <div class="swiffy-slider slider-item-helper slider-item-show2" style="--swiffy-slider-item-count: 2;">

charlesaloaye commented 2 years ago

okay thanks so much

On Mon, Aug 29, 2022 at 12:28 PM Nicolai Høeg Pedersen < @.***> wrote:

Closed #52 https://github.com/dynamicweb/swiffy-slider/issues/52 as completed.

— Reply to this email directly, view it on GitHub https://github.com/dynamicweb/swiffy-slider/issues/52#event-7277721991, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFBTPM3TEABVLAOXIGLGMWTV3SNFBANCNFSM57ZNBGIQ . You are receiving this because you authored the thread.Message ID: @.***>

-- https://about.me/sedenuc?promo=email_sig&utm_source=product&utm_medium=email_sig&utm_campaign=gmail_api&utm_content=thumb Sedenu Charles Aloaye about.me/sedenuc https://about.me/sedenuc?promo=email_sig&utm_source=product&utm_medium=email_sig&utm_campaign=gmail_api&utm_content=thumb

nicped commented 2 years ago

I have added a slider-item-show2-sm class that will make 2 slides on small devices - will be out with next release of the slider.

charlesaloaye commented 2 years ago

Exactly I tried this thinking it will work on mobile devices but couldn’t get that so I altered your code by writing internal css.

swiffy-slider { —swiffy-slider-item-count: 2 !important;

}

And it works..

So I will undo and use this new class you just created.

Thanks so much

On Mon, Aug 29, 2022 at 9:21 PM Nicolai Høeg Pedersen < @.***> wrote:

I have added a slider-item-show2-sm class that will make 2 slides on small devices - will be out with next release of the slider.

— Reply to this email directly, view it on GitHub https://github.com/dynamicweb/swiffy-slider/issues/52#issuecomment-1230819756, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFBTPM4L3GDJFEQULY4II5LV3ULUHANCNFSM57ZNBGIQ . You are receiving this because you authored the thread.Message ID: @.***>

-- https://about.me/sedenuc?promo=email_sig&utm_source=product&utm_medium=email_sig&utm_campaign=gmail_api&utm_content=thumb Sedenu Charles Aloaye about.me/sedenuc https://about.me/sedenuc?promo=email_sig&utm_source=product&utm_medium=email_sig&utm_campaign=gmail_api&utm_content=thumb