search

dynastyprocess / data

An open-data fantasy football repository, maintained by DynastyProcess.com
https://dynastyprocess.com
GNU General Public License v3.0
73 stars 19 forks source link

Add gsis_id and pbp_id to missing_ids.csv #20

Closed trojanguard25 closed 3 years ago

trojanguard25 commented 3 years ago

Parsed the roster data from https://github.com/mrcaseb/nflfastR-roster to get missing gsis_ids and new pbp_ids.

This should help fix #15.

tanho63 commented 3 years ago

Looks great to me - I'm going to leave this open here for now as a nagging reminder to myself to sort out the back-end SQL that'll get it into the dp_playerids.csv file properly. Just finishing the last bits of a release for ffscrapr and I should be back to this ~next week

tanho63 commented 3 years ago

Thanks so much! I don't know that nflfastr_rosters currently provides the pbp ID at all, but I plan to bring in the extra gsis_ids