search

dynastyprocess / data

An open-data fantasy football repository, maintained by DynastyProcess.com
https://dynastyprocess.com
GNU General Public License v3.0
73 stars 19 forks source link

[Data Request/Offer Of Help] 2021 Rookies #22

Closed danabrey closed 3 years ago

danabrey commented 3 years ago

Lots of missing IDs for 2021 rookies on db_playerids.csv - I'll happily try to gather some together this coming weekend unless you have it in the pipeline?

tanho63 commented 3 years ago

Been dabbling with data pipeline work for quite a while - should have an update in the near-ish future!

tanho63 commented 3 years ago

Hiya! Just finished up some automated tooling as of most recent commit that should clean up the 2021 rookies significantly, please give it a spin!

danabrey commented 3 years ago

Awesome! Working great, thanks.

One question just to reassure me - the players.csv used to have age as a property, right? I've switched to taking age directly from MFL now, but I just want to make sure I'm not going mad :)

danabrey commented 3 years ago

Just one funky issue so far (you know you love those). I've had a few emails from Terrace Marshall truthers asking me why I'm declaring him a bust already. While my temptation was to double down on that accidental conclusion...

Terrace Marshall's fantasypros_id in players.csv is 23242, but in values.csv it's 20134.

danabrey commented 3 years ago

Kenny Gainwell has a similar fate.

tanho63 commented 3 years ago

Blast! I did mean for age to be included. Also grah on those funny ones, I’ll check the joins

- Tan Ho

From: Dan Abrey @.> Sent: Wednesday, May 12, 2021 6:44:47 AM To: dynastyprocess/data @.> Cc: Tan Ho @.>; Comment @.> Subject: Re: [dynastyprocess/data] [Data Request/Offer Of Help] 2021 Rookies (#22)

Kenny Gainwell has a similar fate.

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/dynastyprocess/data/issues/22#issuecomment-839670702, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AJCRZ37HKYOYSM7CHOAFX23TNJLZ7ANCNFSM44DB2RMA.

tanho63 commented 3 years ago

Joins here. Looks like FP switches over their post-draft IDs, so it should be reflected in tomorrow's FP values build image

tanho63 commented 3 years ago

Also thank goodness for sportsdata_ids because switching between Kenny and Kenneth Gainwell would have driven me bananas

tanho63 commented 3 years ago

Age should be fixed now!

danabrey commented 3 years ago

Awesome, thanks!

tanho63 commented 3 years ago

Looks like sync went well! (Checked my own dynastyassistant scores 😂)

I'll close this off for now, please feel free to open new issues as necessary!

danabrey commented 3 years ago

Really appreciate it, thanks!

Yep, we're getting rookies syncing fine now, lots of happy people.