Open TheMathNinja opened 2 years ago
Just noticed this issue. Got IDs in question? easier for me to poke at
Your df is showing Randy Gregory: 3895806 Nick Williams: 15882
Mine was showing Randy Gregory: 3040479 Nick Williams: 2317118
Hmm. It looks like these guys have two separate profiles: RG https://www.espn.com/nfl/player/stats/_/id/3895806 https://www.espn.com/nfl/player/stats/_/id/3040479
NW https://www.espn.com/nfl/player/stats/_/id/15882 https://www.espn.com/nfl/player/stats/_/id/2317118
Probably should be corrected via missing_ids.csv again
Tan Ho
On Mon, Sep 27, 2021 at 2:57 PM Mike Filicicchia @.***> wrote:
Your df is showing Randy Gregory: 3895806 Nick Williams: 15882
Mine was showing Randy Gregory: 3040479 Nick Williams: 2317118
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/dynastyprocess/data/issues/28#issuecomment-928180440, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJCRZ32DEVRMNSLYBKEACX3UEC5BPANCNFSM5EJMEE6A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
I think the Randy Gregory and Nick Williams espn_id variables might be wrong in dp_playerids(). I'm working on updating the espn_id and using the ffespn package, the only IDs that aren't matching are these two players. Not sure which is right/wrong.