search

dynastyprocess / data

An open-data fantasy football repository, maintained by DynastyProcess.com
https://dynastyprocess.com
GNU General Public License v3.0
73 stars 19 forks source link

Add ESPN ID's for 2023 rookies #45

Closed TheMathNinja closed 12 months ago

TheMathNinja commented 1 year ago

Hi guys,

I'd like to give a try at a pull request updating ESPN ID's for the 2023 rookies. I'm noticing that the missing ID's file doesn't have 2023 rookies. Should I submit a Pull Request for db_playerids.csv instead?

tanho63 commented 1 year ago

db_playerids.csv

No, this is automatically generated and would be overwritten by the pipeline. If the missing ID's file doesn't have 2023 rookies, you'll need to track down the corresponding MFL ID for the rookie you want to add and then append it to the CSV

TheMathNinja commented 1 year ago

Ok I submitted a pull request for the missing ID's file.

TheMathNinja commented 1 year ago

Any updates on my Pull Request? Also, I'm noticing that ffscrapr::espn_players() already contains all the necessary Player ID's. Why can't these be imported into ffscrapr::dp_playerids() automatically?