search

dynastyprocess / data

An open-data fantasy football repository, maintained by DynastyProcess.com
https://dynastyprocess.com
GNU General Public License v3.0
71 stars 19 forks source link

[Data Bug] gsis_id not updating automatically #48

Closed TheMathNinja closed 11 months ago

TheMathNinja commented 11 months ago

Describe the data bug There are many gsis_idvalues missing for new players like Ahmad Gardner in nflreadr::load_ff_playerids(), but these same gsis_id values are available via nflreadr::load_player_stats(). It seems like nflreadr::load_ff_playerids() should load gsis_id automatically from nflreadr::load_player_stats() automatically so as to allow for joins to other ID variables.

tanho63 commented 11 months ago

these automatic mappings broadly inherit from nflreadr load_players and load_rosters, and relies on a connection by espn_id, sportradar_id, or sleeper_id. Looks like Sleeper has stopped updating gsis_ids which has slowed down gsis mappings substantially.