[Data Bug] CBS Ids truncated for 2024 Players

dynastyprocess / data

An open-data fantasy football repository, maintained by DynastyProcess.com

https://dynastyprocess.com

GNU General Public License v3.0

78 stars 19 forks source link

[Data Bug] CBS Ids truncated for 2024 Players #64

Open jplata opened 1 month ago

jplata commented 1 month ago

Describe the data bug It would appear cbs_id column for many (all?) new players for 2024 are missing the final digit.

Which file is having trouble? db_playerids.csv

Expected data Example:

Jonathon Brooks cbs_id in file: 2673070
Jonathon Brooks actual cbs_id: 26730706
Malik Nabers cbs_id in file: 2669776
Malik Nabers actual cbs_id: 26697761

tanho63 commented 1 month ago

Hm, this is strange. I think we get these IDs from the MFL API. Do you have a list of all the ones that are wrong ?

jplata commented 1 month ago

I don't have a full list, I was pulling in 2024 Draft Data for a league, and noticed it was not matching on the 2024 rookies - so my assumption is any new players added in 2024 could be wrong.

jplata commented 2 weeks ago

Should we open a ticket w/ MFL to see if they can resolve the CBS player ids? Or any other known solutions?

tanho63 commented 2 weeks ago

Yeah, it could be worth trying with MFL support, would you like to give that a go?