dynatrace-extensions / dt-extensions-python-sdk

Dynatrace Python Extensions SDK
https://dynatrace-extensions.github.io/dt-extensions-python-sdk/
MIT License
8 stars 2 forks source link

updated setup.py template to read setup metadata from existing json/yaml files. #76

Closed JosephHobbs closed 3 weeks ago

JosephHobbs commented 3 weeks ago

I noticed in the latest version of the SDK that it was reading the version file from the extension.yaml file. My thought was, why not read the other parameters from the extension.yaml activationSchema.json files too? This eliminates the need to duplicate things like author, version, etc...

dlopes7 commented 3 weeks ago

This looks cool, but unfortunately we can't accept this as certain internal tools we use such as snyk would be unable to parse the setup.py file

When it parses it, it doesn't have access to the extension.yaml file and all of these would break.

dlopes7 commented 3 weeks ago

We also can't add pyyaml as a dependency to every extension

JosephHobbs commented 3 weeks ago

I only used PyYaml because it's already a dependency in the SDK

dlopes7 commented 3 weeks ago

Yes but adding it to setup.py makes it a requirement on the final extension build

The AG and OA won't have pyyaml and won't be able to install the extension

JosephHobbs commented 3 weeks ago

Ok, so what if I...

Would that be valuable/acceptable?