Bugfix - allow for using VPC networks with custom subnet creation

dynatrace-oss / dynatrace-gcp-monitor

Dynatrace integration for Google Cloud Platform monitoring

https://www.dynatrace.com/support/help/technology-support/cloud-platforms/google-cloud-platform/

Apache License 2.0

35 stars 20 forks source link

Bugfix - allow for using VPC networks with custom subnet creation #510

Closed emjot13-dynatrace closed 2 months ago

emjot13-dynatrace commented 2 months ago

Add an option to use the VPCs created with custom subnets for cluster creation. More context: when creating a VPC network the default option is creating custom subnets in this network, then when this network is passed in the values.yaml, creating an autopilot cluster would fail because no subnet was specified. Now it's possible to use VPC networks with both automatic and custom subnets. Additionally, added some small cleaning, mainly breaking too long lines and fixing small inconsistencies.

joaquinfilipic-dynatrace commented 2 months ago

LGMT. 1 question: Any adjustment in docs required? if so it is also in scope of this bug?

True, docs need the new params

sonarcloud[bot] commented 2 months ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud