dynatrace-oss / logstash-output-dynatrace

A Logstash output plugin for sending logs to Dynatrace
4 stars 1 forks source link

Rewrite plugin using http client mixin #28

Closed dyladan closed 1 year ago

dyladan commented 1 year ago

Parts of this rewrite come from https://github.com/logstash-plugins/logstash-output-http

Uses https://github.com/logstash-plugins/logstash-mixin-http_client

dyladan commented 1 year ago

Looks like the ssl_verification_mode option for logstash-mixin-http_client was only introduced in 7.1.0, which means that the option will have no effect in any version of logstash which provides a lower version of the mixin than that. It looks like that means the option will only work in logstash >= 8.1.0. In previous versions, the SSL verification cannot be turned off. 8.1.0 was released just over a year ago.

I suggest that we move forward with this change, but document that in order to use the ssl_verify_none option with a version of logstash older than 8.1.0, version 0.3.2 of this plugin must be used.

pirgeo commented 1 year ago

Putting my approval here mainly for the wording parts, I do not have enough Ruby experience to review this thoroughly.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication