Exponential backoff and testing

dynatrace-oss / logstash-output-dynatrace

A Logstash output plugin for sending logs to Dynatrace

4 stars 1 forks source link

Exponential backoff and testing #8

Closed dyladan closed 3 years ago

dyladan commented 3 years ago

I removed the sinatra server from the tests because it was causing issues locally. Instead I just have a send method which is mocked.

dyladan commented 3 years ago

Received a reply from logstash https://github.com/elastic/logstash/issues/12947#issuecomment-876564582

Takeaway: Remove concurrency :single since we don't store state. With :single we block the other threads anyway since they wait to enter the block. Backpressure on the system is not a problem since the queue eventually will drop chunks to prevent a crash.

dyladan commented 3 years ago

Travis is not reporting the status. Going to try to close and reopen the PR