search

dynatrace-oss / progressiveDelivery-masterclass

Apache License 2.0
4 stars 11 forks source link

Keptn Workloads dashboard: Deployments Succeeded "No data" #23

Closed agardnerIT closed 1 year ago

agardnerIT commented 1 year ago

There has been a deployment but the tile is empty.

image image
agardnerIT commented 1 year ago

Metric should be keptn_deployment_count_total not keptn_deployment_count

https://github.com/AloisReitbauer/progressiveDelivery-masterclass/blob/b933f441ff8bba16b7c9252e6d3a11e00cec09bf/gitops/manifests/prometheus-grafana/grafana-dashboard-keptn-workloads.yaml#L87

and

https://github.com/AloisReitbauer/progressiveDelivery-masterclass/blob/b933f441ff8bba16b7c9252e6d3a11e00cec09bf/gitops/manifests/prometheus-grafana/grafana-dashboard-keptn-workloads.yaml#L222

We should also commit these fixes back upstream. Interestingly the line numbers are different so grafana-dashboard-keptn-workloads.yaml somehow diverges from that of the upstream:

https://github.com/keptn-sandbox/klt-on-k3s-with-argocd/blob/817967fedec9686972d1e6b717510d242f5c21f2/setup/observability/config/prometheus/grafana-dashboard-keptn-workloads.yaml#L90

https://github.com/keptn-sandbox/klt-on-k3s-with-argocd/blob/817967fedec9686972d1e6b717510d242f5c21f2/setup/observability/config/prometheus/grafana-dashboard-keptn-workloads.yaml#L229

agardnerIT commented 1 year ago

This will also affect the "keptn overview" dashboard as it uses the same metric.

https://github.com/AloisReitbauer/progressiveDelivery-masterclass/blob/4246d6c30b3e3a36fa6df99c4a7820c91b3398c5/gitops/manifests/prometheus-grafana/grafana-dashboard-keptn-overview.yaml#L766