Closed agardnerIT closed 1 year ago
https://github.com/AloisReitbauer/progressiveDelivery-masterclass/blob/b933f441ff8bba16b7c9252e6d3a11e00cec09bf/demoapp/app.js#L71C2-L71C71
The demo app code is currently requesting a boolean but my-flag is defined as a string:
my-flag
https://github.com/AloisReitbauer/progressiveDelivery-masterclass/blob/b933f441ff8bba16b7c9252e6d3a11e00cec09bf/gitops/manifests/featureflags/featureflags.yaml#L12
Fix: Change "true": "true" to "true": true and "false": "false" to "false": false
"true": "true"
"true": true
"false": "false"
"false": false
OR change getBooleanValue to getStringValue
getBooleanValue
getStringValue
Because the intention is a boolean, it makes more sense to go with the first fix.
https://github.com/AloisReitbauer/progressiveDelivery-masterclass/blob/b933f441ff8bba16b7c9252e6d3a11e00cec09bf/demoapp/app.js#L71C2-L71C71
The demo app code is currently requesting a boolean but
my-flagis defined as a string:https://github.com/AloisReitbauer/progressiveDelivery-masterclass/blob/b933f441ff8bba16b7c9252e6d3a11e00cec09bf/gitops/manifests/featureflags/featureflags.yaml#L12
Fix: Change
"true": "true"to"true": trueand"false": "false"to"false": falseOR change
getBooleanValuetogetStringValueBecause the intention is a boolean, it makes more sense to go with the first fix.