search

dynatrace-oss / progressiveDelivery-masterclass

Apache License 2.0
4 stars 11 forks source link

Can kubectl patch be removed from Makefile #74

Closed agardnerIT closed 1 year ago

agardnerIT commented 1 year ago

The Makefile contains a kubectl patch command but that same command exists declaratively in the argo-cd YAML:

Can the line in the Makefile be removed?

https://github.com/AloisReitbauer/progressiveDelivery-masterclass/blob/dd896337a3cd82d01ddc1f4d43c007706320c863/Makefile#L17

https://github.com/AloisReitbauer/progressiveDelivery-masterclass/blob/main/gitops/manifests/argo-config/argocd-cm.yaml

agardnerIT commented 1 year ago

Done: https://github.com/dynatrace-oss/progressiveDelivery-masterclass/commit/35e93c4e624e1c984078a6c4e8a0ad1a63055d4a