search

dynatrace-oss / progressiveDelivery-masterclass

Apache License 2.0
4 stars 11 forks source link

Demo App is resetted to the initial Version #80

Open heckelmann opened 1 year ago

heckelmann commented 1 year ago

The current app.js (https://github.com/AloisReitbauer/progressiveDelivery-masterclass/blob/main/demoapp/app.js) is the minimal version of the app without Otel and FF.

Should we revert this commit (https://github.com/AloisReitbauer/progressiveDelivery-masterclass/commit/4ff275a710c7ae864354aed45b4f0b0092c76d47). I guess it was accidentally overwritten.

agardnerIT commented 1 year ago

This is the case because the documentation states that we built that as we go. So it made no sense to have OTEL and FFs pre-installed. So I removed it to match the documentation.

Now though, with the codespaces approach, it seems we're going for a "already-on" version on first install. So yes, I agree we need to revert to the "already instrumented" app version.