search

dyne / frei0r

A large collection of free and portable video plugins
https://frei0r.dyne.org/
GNU General Public License v2.0
419 stars 90 forks source link

Support MSYS2/mingw-w64 #113

Closed mingwandroid closed 3 years ago

mingwandroid commented 3 years ago

Switching from $dayjob to $other-opensource-stuff .. this allows building on MSYS2/mingw-w64. I plan to submit a PR soon to MSYS2 for inclusion.

Thanks for your kind reviews!

mingwandroid commented 3 years ago

Oh, the failure we avoid here is:

/bin/sh ../libtool  --tag=CC --tag=disable-static  --mode=link gcc -I/c/opt/r/w/mingw-w64-frei0r-plugins/src/frei0r-plugins-1.7.0/include -Waddress -Wtype-limits -Wsign-compare -march=x86-64 -mtune=generic -O2 -pipe -module -avoid-version -lm -export-dynamic -pipe -Wl,--dynamicbase,--high-entropy-va,--nxcompat,--default-image-base-high -o alphainjection.la -rpath /mingw64/lib/frei0r-1 mixer2/alphainjection/alphainjection.lo
/bin/sh ../libtool  --tag=CXX --tag=disable-static  --mode=link g++  -march=x86-64 -mtune=generic -O2 -pipe -module -avoid-version -lm -export-dynamic -pipe -Wl,--dynamicbase,--high-entropy-va,--nxcompat,--default-image-base-high -o alphaout.la -rpath /mingw64/lib/frei0r-1 mixer2/alphaout/alphaout.lo
libtool:   error: can't build x86_64-w64-mingw32 shared library unless -no-undefined is specified
ddennedy commented 3 years ago

FYI, CMake works for me in msys2.

mingwandroid commented 3 years ago

Sure, that's great, but I'd like to use autotools personally!

mingwandroid commented 3 years ago

This isn't quite ready yet.

mingwandroid commented 3 years ago

I think this is ready for review now.

mingwandroid commented 3 years ago

Here is my PR to add frei0r to MSYS2: https://github.com/msys2/MINGW-packages/pull/7367

lazka commented 3 years ago

What's the point of adding our CI scripts here? Are there any PKGBUILDs?

See for example https://github.com/harfbuzz/harfbuzz/blob/master/.github/workflows/msys2-ci.yml how to add MSYS2 CI

mingwandroid commented 3 years ago

Thanks. I'll read up and fix it. I'll also split adding ci into a separate pr.

mingwandroid commented 3 years ago

Hi @ddennedy, I removed all the GitHub actions stuff from this PR and think the rest is ready for a re-review if you had time?