fix MSVC compilation - Githubissues

dyne / frei0r

A large collection of free and portable video plugins

https://frei0r.dyne.org/

GNU General Public License v2.0

419 stars 90 forks source link

fix MSVC compilation #114

Closed eszlari closed 1 year ago

eszlari commented 3 years ago

The following filters needed to be disabled because of Variable Length Arrays (VLA), but are enabled when compiling with clang-cl:

curves
d90stairsteppingfix
dither

ddennedy commented 3 years ago

This looks good to me, but I have not tested it myself. I trust this contributor as he is helping MLT and Shotcut convert to CMake and maintains many Flatpaks for many projects.

eszlari commented 3 years ago

btw: My intention is to add frei0r to https://github.com/microsoft/vcpkg.

jaromil commented 1 year ago

@eszlari can you help me understand how to best resolve this conflict?

also, do you think that the build you are trying to enable can be in some way reproduced by GitHub actions?

jaromil commented 1 year ago

conflicts resolved, msvc build goes well

will try to include it into the upcoming release build, see #130

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 1.9.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: