search

dyne / frei0r

A large collection of free and portable video plugins
https://frei0r.dyne.org/
GNU General Public License v2.0
419 stars 91 forks source link

clang-format the C and C++ source code #172

Closed Jonadabe closed 4 months ago

Jonadabe commented 1 year ago

Hi everyone,

It's awesome all the work in here.

What do you think if all the source code had the same formatting? Well, clang-format could be an answer. https://clang.llvm.org/docs/ClangFormatStyleOptions.html https://github.com/llvm/llvm-project/releases/tag/llvmorg-17.0.6 (with releases for all platform)

Another suggestion would be the adopting of .editorconfig repo here: https://github.com/editorconfig

Maybe not, but still I must suggest it strongly, and you decide what's best for the project. Thank you all, again!

jaromil commented 4 months ago

I have two reasons against this proposal, in no particular order:

  1. lose trace of coding style by different contributors, which has some historical relevance and in future may help to distinguish human-written code from machine.
  2. introduce a commit that will force a change upon all code and so may create disruption for any future merging of code that references versions before this modification.
Jonadabe commented 4 months ago

Hi there.

In part I can understand your point. But what if the commits where made file by file? Would you still be against it? Wheren't it be better to read the actual code and to document it or maybe to improve it somehow in the near future? Don't missinterpret my comments please. Am I missing something here beyond my actual understanding? Thanks for your work!