search

dyne / frei0r

A large collection of free and portable video plugins
https://frei0r.dyne.org/
GNU General Public License v2.0
419 stars 91 forks source link

Lack of kaleidoscope filter #174

Closed gbendy closed 11 months ago

gbendy commented 12 months ago

Would you be open to a PR to add my kaleid0sc0pe filter to the core codebase?

https://github.com/gbendy/kaleidoscope/

jaromil commented 12 months ago

@gbendy you are welcome! is there a way to build it without SSE specific instructions?

gbendy commented 12 months ago

Yes, there's a CMake option. Can default that to off. Or can just make it rely on the __SSE2__ define that other filters like aech0r/colgate/medians use,

BTW, I got it building in the frei0r codebase today. Just haven't tested the output yet.

jaromil commented 12 months ago

@gbendy excellent, will follow up on the PR

jaromil commented 11 months ago

dears, any clues about this? https://github.com/rdp/ffmpeg-windows-build-helpers/issues/706 I am not an expert of latest C++ stuff nor Win64 platform, so worst case scenario I'd skip build for that platform but it's a pity

gbendy commented 11 months ago

Cross compiler configuration related. Can detect and deal with the problem at cmake time https://github.com/dyne/frei0r/pull/179

gbendy commented 11 months ago

All works fine if you build in native Win64. Seems so bizarre that even now some C++11 features aren't supported in some compiler setups.