search

dyne / frei0r

A large collection of free and portable video plugins
https://frei0r.dyne.org/
GNU General Public License v2.0
419 stars 91 forks source link

New effect - gate weave #180

Closed esmane closed 2 months ago

esmane commented 8 months ago

I have no idea how any of this github stuff works so if I did something incorrectly let me know. My effect simulates film gate weave by sort of randomly moving the frame around every frame.

jaromil commented 6 months ago

Hey mate welcome!! appreciate your contribution, PR looks fine and code smells wise :^) haven't tried it yet myself so please be patient a little while more, will run the filters through some tests and hopefully merge this. No further action needed on your side, unless you have more fixes to your code. Cheers!

esmane commented 6 months ago

Hey mate welcome!! appreciate your contribution, PR looks fine and code smells wise :^) haven't tried it yet myself so please be patient a little while more, will run the filters through some tests and hopefully merge this. No further action needed on your side, unless you have more fixes to your code. Cheers!

No problems waiting! I think I'm pretty happy with the way my effects work and look at least for now. I'm not sure if it matters but my video editor of choice is Kdenlive and as such that's what I've been testing it with. I downloaded Shotcut just to see but no luck getting them to appear in the editor. Thanks again!

esmane commented 2 months ago

Thank you! now I need to make my effects thread safe haha