search

dyne / frei0r

A large collection of free and portable video plugins
https://frei0r.dyne.org/
GNU General Public License v2.0
427 stars 89 forks source link

rgbsplit0r : add both positive and negative directions #25

Closed d-j-a-y closed 6 years ago

d-j-a-y commented 6 years ago

horizontal : right/left vertical : up/down

ddennedy commented 6 years ago

This appears to change the meaning of existing values (values save in a script or project file of an editor). I do not know if that can be avoided but at the very least you should increment the plugin version - major version if the interface semantics are broken by new interpretation of value range.

d-j-a-y commented 6 years ago

This appears to change the meaning of existing values ...

yes that's right ... i update my request with new major version.

ddennedy commented 6 years ago

@namikiri Can you please review this since it affects the plugin you created?

namikiri commented 6 years ago

Unfortunately I can't pull and build the plugin to test it, so I will rely on @d-j-a-y's experience. He said that he wanted to make similar one and suggested me to make double-directional version. He did it for me and I accept it, that's a very good improvement. Thank you a lot, @d-j-a-y!

I approve the changes.