Use the OpenCV C++ API in facedetect.cpp

dyne / frei0r

A large collection of free and portable video plugins

https://frei0r.dyne.org/

GNU General Public License v2.0

427 stars 89 forks source link

Use the OpenCV C++ API in facedetect.cpp #34

Closed rrrapha closed 5 years ago

rrrapha commented 5 years ago

The newer C++ API seems to be preferred way to use OpenCV. The C API is supported for backward compatibility only.

I have tested this with kdenlive on OpenBSD (OpenCV 2.4.13).

With the C API, I was running into issues like this one: https://github.com/opencv/opencv/issues/5889

If you like the idea, I can have a look at facebl0r too.

jaromil commented 5 years ago

hi Raphale, yes FWIW I like the idea, thanks! not sure what @ddennedy thinks about it. I've tested it building with OpenCV 3.2.0.

ddennedy commented 5 years ago

I agree with it in principle. I just have not had a chance yet to test it. I think a big change like this should be tested perhaps by more than just the contributor.