dyne / frei0r

A large collection of free and portable video plugins
https://frei0r.dyne.org/
GNU General Public License v2.0
427 stars 89 forks source link

Add glitch0r plugin #7

Closed namikiri closed 7 years ago

namikiri commented 7 years ago

I love glitches. Glitches love me. Why we shouldn't make a nice effect for such an interesting framew0rk?

Thank you for inspiration, frei0r maintainers. The video on frei0r.dyne.org made me happy and inspired me to write this little plugin.

Hope this will be helpful :3

jaromil commented 7 years ago

hi, thanks for the contribution! can you rebase all commits into a single one?

namikiri commented 7 years ago

@jaromil Yes, of course. Just did it.

I am new to Github community and I am planning to create another plugin, should I rebase further commits again before making a new pull req?

ddennedy commented 7 years ago

The GitHub web UI makes it easy to squash commits or rebase and merge. However, your rebase does make it easier to review and add comments to lines.

ddennedy commented 7 years ago

Thank you for your contribution, @namikiri !

namikiri commented 7 years ago

Thank you @ddennedy for your review! I've fixed everything that you pointed in my code.

First time I thought that glitching means total data distortion, but then I tried saving alpha channel and it really makes sense. Thank you for pointing me on it.

Should I squash this commit too?