dyne / frei0r

A large collection of free and portable video plugins
https://frei0r.dyne.org/
GNU General Public License v2.0
437 stars 91 forks source link

Add FX aech0r . Aim to simulate an analog video echo. #73

Closed d-j-a-y closed 4 years ago

d-j-a-y commented 5 years ago

TODO : Fix sse2 version - SSE2WIP RGB plane fade is not ported in sse2 (m_rgb and m_flag_b tests)

files  : src/Makefile.am src/filter/CMakeLists.txt

jaromil commented 5 years ago

any chance someone can try this in a host with different parameters?

jaromil commented 5 years ago

thanks Dan. Given the issues I think this won't make it in the release on time.

ddennedy commented 5 years ago

The issues are small that could be addressed very quickly for the release without imposing risk, but I do not know how to fix the most meaningful of them myself.

rschiang commented 4 years ago

@d-j-a-y could you explain in further details how these parameters work? There are some preliminary translations done in downstream projects already, but we’re pretty confused what “Plans fade” and the rest of the parameters are.

(cc @akcansoft)

d-j-a-y commented 4 years ago

@rschiang , it's true, i will do my best to fix me contribution. maybe removing sse2 specifcs and keeping 'layers fade', or removing this strange and glitchy parameter ... and found an explicit naming, description.

Fill free to build and play with it ... ! :-) Tips :

Nota: 'Plans' is a french word,(lost in the code), relative to rgb layers

aechor-fx

ddennedy commented 4 years ago

OK, I am basically OK with this now. We can merge this if you are ready.

d-j-a-y commented 4 years ago

Thanks to all of you!

ddennedy commented 4 years ago

@d-j-a-y ready to merge, or are there other changes you plan soon?

d-j-a-y commented 4 years ago

@d-j-a-y ready to merge, or are there other changes you plan soon?

yes, @ddennedy, ready to merge.