search

dyne / frei0r

A large collection of free and portable video plugins
https://frei0r.dyne.org/
GNU General Public License v2.0
437 stars 91 forks source link

Installation location of pkgconfig files is hardcoded #79

Closed Othko97 closed 5 years ago

Othko97 commented 5 years ago

Currently the installation location of pkgconfig files is hardcoded to ${CMAKE_INSTALL_PREFIX}/lib/pkgconfig, which causes issues if the system pkg-config is configured to use a different location.

For example in freedesktop-sdk we use debian's multiarch system, with our pkg-config path configured to be in /usr/lib/${multiarch-triplet}/pkgconfig. As a result we wouldn't be able to use pkg-config to detect frei0r. See the work to add frei0r support in freedesktop-sdk here for an example of the issue.

ddennedy commented 5 years ago

Will using CMAKE_INSTALL_LIBDIR work for you?

Othko97 commented 5 years ago

We already set CMAKE_INSTALL_LIBDIR, the problem is that the installation is hardcoded as lib/pkgconfig. If preferred I can change #80 to just use ${CMAKE_INSTALL_DIR}/pkgconfig, as this seems sensible and less maintenance than an option.

ddennedy commented 5 years ago

frei0r using libdir is what I meant. I would prefer the smaller patch you suggested. Thanks