Clamp the ranges for 'channel' and 'histogramPosition' to valid numbers.

hzeller commented 5 years ago

Before, it was possible to set non-sense values outside the ranges which resulted in glitches (at best), as these values were directly used in switch/case statements.

Document the valid ranges in the 'explanation' documentation string.

While at it

make channel and histogramPosition an enumeration.
showHistogram is only a boolean. Represent internally as char.
There are bunch of places that switch/case through the parameter indexes. Make that an enum as well so that there is a more readable relationship between these.

Also, fix some inconsistent indentation and superfluous spaces before newlines.

hzeller commented 5 years ago

Also CC Maksim @m4ks1k as the original author.

ddennedy commented 5 years ago

I agree to these changes, but I will wait to see if you choose to update based on my comments before merging.

jaromil commented 5 years ago

I appreciate the clarity this PR brings, but it would be much better to not mix whitespace/indentation cleanups with changes. I don't take this as a blocking issue however.

dyne / frei0r

Clamp the ranges for 'channel' and 'histogramPosition' to valid numbers. #83