search

dyne / frei0r

A large collection of free and portable video plugins
https://frei0r.dyne.org/
GNU General Public License v2.0
420 stars 90 forks source link

scanline0r: Smoother scanline appearance #86

Closed thp closed 4 years ago

thp commented 4 years ago

Make the scanline effect be 1 lighter line, 1 darker line (no black lines), alternating. Brighten up the odd lines (and darken the even ones) so that the average brightness isn't affected too much (these values -- 150 and 64 might need tweaking).

The scanline0r filter can be used for displaying a live captured composite video signal in Cheese in combination with the GStreamer plugin and the following file in /usr/share/gnome-video-effects/scanlines.effect:

[Effect]
Encoding=UTF-8
Name=Scanlines
Comment=Scanline filter from frei0r
PipelineDescription=frei0r-filter-scanline0r

Example effect, original image:

no-scanlines

With the patched scanline0r effect:

with-scanlines

thp commented 4 years ago

Bumped minor version in the PR now and also fixed the description (black was misspelled, and with this change, it's not fully black, so changed it to "dark" instead).

thp commented 4 years ago

Related gnome-video-effects merge request 4 (gnome-video-effects is a downstream user of the frei0r library via GStreamer).

ddennedy commented 4 years ago

I am just giving this PR a couple of more days to allow any objection before I merge it for you.