dyne / reflow-os

Base scripts to run Reflow OS
7 stars 2 forks source link

Wish: Searching or Filtering Economic Events and Economic Resources by trackingIdentifier #5

Open ocataco opened 2 years ago

ocataco commented 2 years ago

In the simulation i'm working on, for example because of how packing and unpacking is implemented, the same 'medical gown' resource will exist at different times at for different owners (and places) identified under more than one reflow os id in its lifetime. This is expected behaviour, and i guess it's the task of a tracking identifier to string back together these resources and events in valueflows.

Thinking ahead, if I would want to create a material passport for one physical medical gown that integrates all it's incarnations, i would have to query all economic resources that have this trackingIdentifier attached, and also all the economic events related to these resources in the system.

It's not clear to me how I would go about it efficiently because the 'filter' queries for economic resource and for economic events do not seem to support the trackingIdentifier as an argument.

mayel commented 2 years ago

Hi @ocataco a refactor or filtering/ordering/pagination is in the pipeline for the ValueFlows API, so I'll make a note to add this as a filter 👍

adam-burns commented 2 years ago

Hi @ocataco a refactor or filtering/ordering/pagination is in the pipeline for the ValueFlows API, so I'll make a note to add this as a filter +1

Hi @mayel any update/expected timeline for ValueFlows filtering with trackingIdentifier as an argument?

Is refactoring filtering/ordering/pagination for the whole ValueFlows API a hard prerequiste?

adam-burns commented 2 years ago

Hi @ocataco can you confirm whether this issue a wish or a tracking and tracing implementation blocking issue?

Thanks

mayel commented 2 years ago

implemented in https://github.com/bonfire-networks/bonfire_valueflows/commit/03f00cb152300a4c583db1de043518eb815277f9

mayel commented 2 years ago

PR to merge into reflowos: https://github.com/dyne/bonfire_valueflows/pull/1