Decide if we should allow "that" in "Given I" such as "Given that I"

dyne / slangroom

Enhance zencode smart contracts with your slang

https://dyne.org/slangroom/

GNU Affero General Public License v3.0

5 stars 1 forks source link

Decide if we should allow "that" in "Given I" such as "Given that I" #46

Open denizenging opened 9 months ago

denizenging commented 9 months ago

pkg/core/src/parser.ts:66

What should be the outcome if "that" isn't provided? Should the parser just consume "that" when it is in there and fallback to not using "that"? I think this sounds reasonable.

denizenging commented 9 months ago

@puria, @andrea-dintino, @jaromil, please comment on this.

jaromil commented 9 months ago

@srfsh the word "that" is not tolerated in zencode. the pronoun "I" is tolerated and fully optional. For more info on the tolerated nop words see https://github.com/dyne/Zenroom/blob/7907284d544534da233098bd44ed6f92bfd99046/src/lua/zencode.lua#L151