dyne / tomb

the Crypto Undertaker
https://dyne.org/software/tomb
GNU General Public License v3.0
1.32k stars 150 forks source link

'Command "check" not recognized' when running 'tomb-qt-create'. #113

Closed logavanc closed 10 years ago

logavanc commented 10 years ago

After I launch the Qt GUI, I click on the "Next" button and immediately get an error (screen shot attached). The command line output is as follows

$> tomb-qt-create tomb [W] Command "check" not recognized. tomb . Try -h for help. tomb [W] Command "check" not recognized. tomb . Try -h for help.

tomb-qt-create

melon3r commented 10 years ago

git log -- extras/qt shows when the Qt GUI was last updated:

commit 3eb93acc18fde81d093f257b630a6f6321877ef8
Author: Jaromil <jaromil@dyne.org>
Date:   Sat May 18 17:29:37 2013 +0200

This proves it unmantained, so it's normal that it fails. The "check" command might have existed in the past, but it doesn't any more. I think the Qt GUI (and maybe other extras) should be removed, unless somebody is going to update and mantain them.

leethax666 commented 10 years ago

same here on mint 17

hellekin commented 10 years ago

The check command was removed in 671350585ea3535835be04b3867aca60d30471f3 (see lines 368 and 2134). That command was checking whether the swap was activated, and in that case, bail out. It doesn't make sense anymore: since then, the _check_swap function was introduced and embedded in the create command.

Maybe that step should be removed. Alternatively, check_swap could be run by itself to provide a specific error message (unencrypted swap). I would favor the former option.

jaromil commented 10 years ago

yes, qt gui is left unmaintained (and zulucrypt does the job) so I will reorg extras/ that are left unmaintained into extras/incomplete/

melon3r commented 10 years ago

Sounds good.