search

dyne / tomb

the Crypto Undertaker
https://dyne.org/software/tomb
GNU General Public License v3.0
1.32k stars 150 forks source link

cmd lock: extend parameters to --filesystem #450

Closed chri2 closed 1 year ago

chri2 commented 1 year ago

The --filesystem option can be used to specify an alternative filesystem used to format the tomb, in place of the default "ext4".

Beside "btrfs" now the following parameters to --filesystem are supported:

"ext3" using operating system defaults "ext4" using operating system defaults "btrfs" for tombs >= 47MB using operating system defaults "btrfsmixedmode" for tombs >=18MB btrfs mixed mode (see mkfs.btrfs(8)) "ext3maxinodes" ext3 with a maximum of inodes (for many small files) "ext4maxinodes" ext4 with a maximum of inodes (for many small files)

These changes help use scenarios in which there is a great number of small files and/or directories in a small filesystem, like e.g. the pass-tomb extension to pass.

jaromil commented 1 year ago

very nice to have sane defaults at hand for common typologies of filesystems. Thanks again for this contribution!

chri2 commented 1 year ago

If I'd want to check from pass-tomb extension whether the new filesystem parameters are available, could I rely on the version being higher than the first release containing this MR or should we extend the --filesystem with some parameter (or no parameter at all) to output a list of supported parameters?

jaromil commented 1 year ago

@chri2 well, I can tag a new release perhaps it is easier. Else I'd rather refer to the installed manpage (which I saw you updated, well done!)

chri2 commented 1 year ago

Else I'd rather refer to the installed manpage

I was thinking about on how to find out from the pass-tomb code which filesystem options are available for the initial creating of a password storage. I'd like to see the default for the filesystem changing depending on the available version of tomb.

Short: A release would be great to have something to check for from pass-tomb :)