search

dyne / tomb

the Crypto Undertaker
https://dyne.org/software/tomb
GNU General Public License v3.0
1.32k stars 151 forks source link

Use $SUDO_ASKPASS if defined. (allows GUI sudo password prompts) #466

Closed ToyKeeper closed 1 year ago

ToyKeeper commented 1 year ago

Use $SUDO_ASKPASS if defined. Allows non-terminal sudo password prompts.

The sudo program checks this env var and uses it, but only if --askpass was given at the command line, or if it thinks there is no terminal. But the terminal detection is unreliable, so give it --askpass if there is an askpass program defined in the environment.

To try it, simply export SUDO_ASKPASS=/usr/bin/ssh-askpass before running tomb.

For me personally, this makes it possible to have a hotkey to run "pass" and "pass tomb" related commands. Without this patch, invoking via hotkey causes my window manager to lock up while waiting for a password on the VT where Xorg was started... and since it's locked up, I can't change to the VT to enter the data it's waiting for. So I have to log in via ssh from another host to recover it.

So, instead of locking up... now it can use a GUI askpass program.

jaromil commented 1 year ago

Make sense! I had some doubts about the use of local for the askpass var inside a conditional branch, but it seems the scope is the whole function so should be OK. Thanks for your contribution!