search

dyne / tomb

the Crypto Undertaker
https://dyne.org/software/tomb
GNU General Public License v3.0
1.32k stars 151 forks source link

Modest `extras/gtomb` update #477

Closed nerun closed 1 year ago

nerun commented 1 year ago
  1. inserted a "wait" statement in the dig, forge, lock and open functions;
  2. replaced soft with hard tabs to maintain code standard;
  3. spelling standardization (canceled to cancelled);
  4. zenity warning function changes;
  5. fixed missing dots.

About Update "1"

Some messages like Success: Tour tomb has been dug in ... was appearing BEFORE the tomb was actually dug. With a wait statement the message appears AFTER the tomb has been created. Similar situations occurred in forge, lock and open functions.

About Update "2"

My previous PR #465 (merged) used soft tabs, because my editor uses soft tabs, but gtomb itself uses hard tabs. Now uniform.

About Update "3"

Most of text is in english British, Canadian, Australian (cancelled) but a few times "cancelled" appears spelled as "canceled" (USA english).

About Update "4"

Just a simplification. All warning messages but one, have title "Warning", that one had title "gtomb". I have moved title to inside the function.

About Update "5"

Self explanatory.

jaromil commented 1 year ago

Thanks!

jaromil commented 1 year ago

would be best to separate the commit changing indentation

nerun commented 1 year ago

Done in PR #478