dyne / tomb

the Crypto Undertaker
https://dyne.org/software/tomb
GNU General Public License v3.0
1.32k stars 151 forks source link

I got error message "is_valid_tomb:local:57: not valid in this context: " when I ran the command "tomb lock -k secrets.tomb.key secrets.tomb" for testing. #487

Closed blueDesert closed 3 months ago

blueDesert commented 1 year ago

Hi guys,

I ran command tomb with parameters dig & forge that was success as below:

[root@/tmp]# tomb dig -s 10 secrets.tomb
tomb  .  Commanded to dig tomb 
tomb (*) Creating a new tomb in secrets.tomb
tomb  .  Generating secrets.tomb of 10MiB
10+0 records in
10+0 records out
10485760 bytes (10 MB) copied, 0.0401147 s, 261 MB/s
-rw------- 1 root root 10M Jul  5 00:09 secrets.tomb
tomb (*) Done digging secrets.tomb
tomb  .  Your tomb is not yet ready, you need to forge a key and lock it:
tomb  .  tomb forge secrets.tomb.key
tomb  .  tomb lock secrets.tomb -k secrets.tomb.key
[root@/tmp]# tomb forge -k secrets.tomb.key 
tomb  .  Commanded to forge key secrets.tomb.key with cipher algorithm AES256
tomb [W] This operation takes time. Keep using this computer on other tasks.
tomb [W] Once done you will be asked to choose a password for your tomb.
tomb [W] To make it faster you can move the mouse around.
tomb [W] If you are on a server, you can use an Entropy Generation Daemon.
512+0 records in
512+0 records out
512 bytes (512 B) copied, 0.00114654 s, 447 kB/s
tomb (*) Choose the password of your key: secrets.tomb.key
tomb  .  (You can also change it later using 'tomb passwd'.)
tomb  .  Key is valid.
tomb  .  Done forging secrets.tomb.key
tomb (*) Your key is ready:
-rw------- 1 root root 894 Jul  5 00:09 secrets.tomb.key

But I got the error message when I was ready to lock it:

[root@/tmp]# tomb lock secrets.tomb -k secrets.tomb.key
tomb [W] File is not yet a tomb: secrets.tomb
is_valid_tomb:local:57: not valid in this context: 

The coreutils version 8.32 were compiled by myself because sha256sum of coreutils v8.22 didn't support parameter zero.

[root@/tmp]# /usr/bin/sha256sum --version
sha256sum (GNU coreutils) 8.32
Copyright (C) 2020 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <https://gnu.org/licenses/gpl.html>.
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Written by Ulrich Drepper, Scott Miller, and David Madore.

System information:

Linux TWNXXXXXXX 3.10.0-1160.90.1.el7.x86_64 #1 SMP Thu May 4 15:21:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
CentOS Linux release 7.9.2009 (Core)

Does anyone have any idea about this problem?

Narrat commented 1 year ago

Two things I noticed:

jaromil commented 6 months ago

This teaches us two lessons in usability:

  1. implement a check on minimum size for dig
  2. support also -k on forge (its intuitive ...)
jaromil commented 3 months ago

The proposed fixes were made in a previous commit.