Resubmission of PR #506: it had conflicts that I didn't know how to resolve, so I did it again.
1. Tomb Listing issue
When listing tombs with tomb list, if there are no tombs open, this failure message is shown:
Line 2668:
_failure "I can't see any ::1 status:: tomb, may they all rest in peace." ${1:-open} }
The problem is that the ::1 status:: is always open. So the message shown will be always:
I can't see any open tomb, may they all rest in peace.
But the word open cannot be translated because it is a variable. In other languages, it sounds bad.
The phrase I can't see any open tomb, may they all rest in peace. is used twice along tomb script, in lines 2832 (index_tombs) and 2946 (search_tombs). So we can safely adopt this phrase also for list_tombs in line 2668.
shouldn't we change the .pot file then and update some translations? perhaps this can be done inside this PR
Yes, you're right! I will update the POT. This also raises other questions though.
As I explained in extras / translations / README ALL .po files are outdated (except pt_BR-2.10.po). They are for Tomb 2.3 not 2.10+. I created that tomb-2.10.pot for this reason in a very old PR already merged if you remember, but the old tomb.pot (for v2.3) was not deleted. I think we should delete that one too, and rename the tomb-2.10.pot to just tomb.pot. Will be a good idea to update the translation PO files with the new version, so translators can choose to update what is needed:
Resubmission of PR #506: it had conflicts that I didn't know how to resolve, so I did it again.
1. Tomb Listing issue
When listing tombs with
tomb list
, if there are no tombs open, this failure message is shown:Line 2668:
The problem is that the
::1 status::
is alwaysopen
. So the message shown will be always:But the word
open
cannot be translated because it is a variable. In other languages, it sounds bad.The phrase
I can't see any open tomb, may they all rest in peace.
is used twice along tomb script, in lines 2832 (index_tombs
) and 2946 (search_tombs
). So we can safely adopt this phrase also forlist_tombs
in line 2668.2. Update POT and translation PO files
About this, @jaromil said:
Yes, you're right! I will update the POT. This also raises other questions though.
As I explained in extras / translations / README ALL
.po
files are outdated (except pt_BR-2.10.po). They are for Tomb 2.3 not 2.10+. I created thattomb-2.10.pot
for this reason in a very old PR already merged if you remember, but the oldtomb.pot
(for v2.3) was not deleted. I think we should delete that one too, and rename thetomb-2.10.pot
to justtomb.pot
. Will be a good idea to update the translation PO files with the new version, so translators can choose to update what is needed: