search

dyninc / dyn-python

Dyn SDK for Python
Other
36 stars 52 forks source link

Add publish parameter to delete methods. #110

Closed anothrNick closed 7 years ago

anothrNick commented 7 years ago

& check publish parameter and implicitPublish.

whisk3y commented 7 years ago

+1 looks good

@Marchowes

Marchowes commented 7 years ago

You forgot DSFFailoverChain Which is not surprising since its easily forgotten :)

Are our customers just looking for this for DSF services? What about Monitors/Notifiers? They probably don't want those, but I figured I'd ask just in case.

anothrNick commented 7 years ago

Thanks I'll update DSFFailoverChain as well.

The docs for Monitors/Notifiers don't mention support for the publish parameter, so I left those out: https://help.dyn.com/delete-dsf-monitor-api/ https://help.dyn.com/delete-notifier-api/

anothrNick commented 7 years ago

Updated

Marchowes commented 7 years ago

if you update the HISTORY.rst file, I'll go ahead and merge this.

anothrNick commented 7 years ago

Updated HISTORY.rst @Marchowes