search

dynmeth / RaphaelLayer

Raphael overlay for Leaflet maps
MIT License
80 stars 25 forks source link

Various fixes #5

Closed Tallmaris closed 11 years ago

Tallmaris commented 11 years ago

packages.json had a comma too much at the end and it was breaking the npm install command.

The Bezier curve now has 2 control points and I think it looks a lot smoother on a map, except maybe for when the source and destination are exactly aligned horizontally or vertically.

The build script now runs the main self-executing function using the "L" parameter coming from the window object... This is to avoid the L still referencing the global L when this is removed from the global scope (for example when injecting the script dynamically). What was happening was that everything was working ok except the _updateRaphaelViewport, which was still using the global L and thus undefined in my case (I am injecting Leaflet and then running noConflict()).

dbhowell commented 11 years ago

Hey Tallmaris, just got back from holidays. Thanks for the contribution.

Can you break this up into separate PR?

I'd like to look into the bezier curve changes more thoroughly before merging but the other changes look good.

Tallmaris commented 11 years ago

HI there,

No problem I'll withdraw this and make two separate PR.