dynotx / liminal-orm

ORM and toolkit to help keep your Benchling schemas and downstream dependencies in sync.
https://dynotx.github.io/liminal-orm/
Apache License 2.0
34 stars 3 forks source link

move field wh name to base field props #53

Closed ndamania00 closed 2 days ago

ndamania00 commented 1 week ago

This PR's main goal is to add the field warehouse name to BaseFieldProperties. This makes the operations for updating warehouse names the same for schemas and fields.

Updating Entity Schema warehouse name:

  b.UpdateEntitySchema('old_warehouse_name', b.BaseSchemaProperties(warehouse_name='new_warehouse_name'))

Updating Entity Schema Field warehouse name:

b.UpdateEntitySchemaField('entity_schema_warehouse_name', 'field_warehouse_name', b.BaseFieldProperties(warehouse_name='new_warehouse_name'))

Some smaller details of this PR: