search

dynup / kpatch

kpatch - live kernel patching
GNU General Public License v2.0
1.49k stars 304 forks source link

Declaration and definition are inconsistent #1384

Closed xky1306102chenhong closed 5 months ago

xky1306102chenhong commented 7 months ago

【In English】 Declaration and definition are inconsistent declaration: image

definition: image

【中文】 声明和定义不一致

joe-lawrence commented 7 months ago

Hi @xky1306102chenhong: good catch. Are you using an automated tool to find such mismatches? Finally, since the insn/ files are copied out of the kernel source (for example see tools/arch/x86/include/asm/inat.h and arch/x86/include/asm/inat.h), this update should be targeted there first.

xky1306102chenhong commented 7 months ago

Hi @xky1306102chenhong: good catch. Are you using an automated tool to find such mismatches? Finally, since the insn/ files are copied out of the kernel source (for example see tools/arch/x86/include/asm/inat.h and arch/x86/include/asm/inat.h), this update should be targeted there first.

Thank you @joe-lawrence very much for your review comments. I noticed it while reading through the code, not through an automated tool. I'm attempting to submit a patch to the Linux Kernel, but it's taking some time as I'm still relatively new to this. If the Linux Kernel accepts my patch, I'll be sure to inform you promptly.

github-actions[bot] commented 5 months ago

This PR has been open for 60 days with no activity and no assignee. It will be closed in 7 days unless a comment is added.

github-actions[bot] commented 5 months ago

This PR was closed because it was inactive for 7 days after being marked stale.