dynverse / dynmethods

A collection of 50+ trajectory inference methods within a common interface 📥📤
https://dynverse.org
Other
119 stars 26 forks source link

Monocle #16

Closed zouter closed 6 years ago

zouter commented 6 years ago

Hello @Xiaojieqiu and @ctrapnell

This issue is for discussing the wrapper for your trajectory inference method, Monocle, which we wrapped for our benchmarking study (10.1101/276907). In our dynmethods framework, we collected some meta information about your method, and created a docker wrapper so that all methods can be easily run and compared. The code for this wrapper is located in docker containers[1][2]. The way this container is structured is described in this vignette.

We created 2 separate wrappers:

We are creating this issue to ensure your method is being evaluated in the way it was designed for. The checklist below contains some important questions for you to have a look at.

The most convenient way for you to test and adapt the wrapper is to install dyno, download and modify these files, and run your method on a dataset of interest or one of our synthetic toy datasets. This is further described in this vignette. Once finished, we prefer that you fork the dynmethods repository, make the necessary changes, and send us a pull request. Alternatively, you can also send us the files and we will make the necessary changes.

If you have any further questions or remarks, feel free to reply to this issue.

Kind regards, @rcannood and @zouter

rcannood commented 6 years ago

I recently saw on twitter that monocle 3 is being released. Should monocle 3 be included in dynmethods?

zouter commented 6 years ago

It is still in alpha release, but it would be great to include it, especially as it competes with PAGA on several fronts (disconnected graphs, scalability, ...). Perhaps @Xiaojieqiu or @ctrapnell can chime in on how we can best handle this?

ctrapnell commented 6 years ago

I would suggest that you not include it until Monocle 3 is declared finished. Monocle 3 isn't even feature complete, and we are likely to change much about how it works both internally and in terms of the interface.

More generally, comparing software that hasn't even been described in a preprint form against published, polished code in some sort of competitive bakeoff just doesn't seem fair. Doing so risks discouraging our group and others from releasing alpha code in the future.

rcannood commented 6 years ago

Hello @ctrapnell,

With the features that you listed in your recent tweets (disjoint trajectories, cycles, high scalability, finding trajectory dependent genes, tests written by Jun Cao), I think it'd be hard for anyone not to get excited by the announcement of Monocle 3. Please don't misinterpret my enthousiasm as an attempt to stifle your group in any form or fashion.

I understand that Monocle 3 is still in an alpha state, and that you would prefer us not to include it as part of this package just yet; that's fine ─ that is why we are asking for your opinion. Would you agree waiting for a bioRxiv / Bioconductor release of Monocle 3 before including it in dynmethods would seem a reasonable approach to take?

On a related note, would you have time to take a look at the dynmethods wrappers for Monocle ICA/DDRTree in the near future? Do you have any suggestions or improvements? Do recent changes in the Monocle code result in a better QC score?

Kind regards, Robrecht

ctrapnell commented 6 years ago

Hi @rcannood -

I'm glad you are excited about it! I didn't mean to snap, either. I do think it's important to have quantitative evaluations of tools. My point was that until there's a paper to go along with the software, it will be hard for the wider community of methods developers to learn what Monocle 3 is doing well vs. the places where other tools' designs are the right way to go.

So I definitely think that waiting until there's at least a pre-print would be good, but perhaps Monocle 3 could be included once the preprints are up but before the papers are actually published. As we did with Monocle 2, Monocle 3 will probably be described in several papers as we bring different chunks of functionality online. We're not entirely sure what the preprint schedule will be exactly, but hopefully the main trajectory code will be described at least on bioRxiv within a couple of months.

Re: the DDRTree wrapper - we haven't had a chance to look at this yet, but will try to do so soon. Thanks for including Monocle 2 in dynmethods, and for keeping an eye on Monocle 3!

C

rcannood commented 6 years ago

I'm closing this issue. If you have any further remarks on the Monocle 2 wrapper (which was updated recently), or if you would like us to add a wrapper for Monocle 3 at some point, feel free to open up a new issue!

Kind regards, Robrecht