dynverse / dynwrap

A common data format and inference environment for single-cell trajectories 📦
https://dynverse.org
Other
14 stars 7 forks source link

Harmonise "model" variable names #122

Closed zouter closed 5 years ago

zouter commented 5 years ago

Right now the first argument of most dynwrap functions can be:

Possible solutions:

Any preference @rcannood ?

zouter commented 5 years ago

Forgot to mention:

zouter commented 5 years ago

I propose the following:

If a wrapper contains a trajectory, use trajectory Otherwise use dataset

This makes the most sense in the two main dynwrap use cases: creating a trajectory and working with it (i.e. adding a root or calculating a dimensionality reduction), and creating a dataset and working with it (i.e. adding prior information or running a TI method)

This proposal is in branch renamefactorisation

zouter commented 5 years ago

To enhance consistency, I added "common" parameters to the dynwrap object. See https://github.com/dynverse/dynwrap/commit/4438600f67b1c42a7b03bf1468f7e5af94e526b5

zouter commented 5 years ago

Fixed by #125