search

dyoo / WeScheme

29 stars 16 forks source link

Logout doesn't logout #24

Closed dyoo closed 12 years ago

dyoo commented 13 years ago

From Emmanuel:

"Log Out" doesn't seem to be working -- when I click "log in", I don't even have to enter a password!

A useful feature would be a "login as adifferent user" button. Wescheme currently autologs me in with my open gmail account, and wiithout opening gmail (a hassle on my phone) I can't logout to login as something else.

bhickey commented 13 years ago

When I implemented this, I had tried discarding the GOOG credentials after setting the WeScheme cookie. This had the nasty effect of logging the user out of unrelated Google services.

dyoo commented 12 years ago

We are now deliberately logging out of google services: the reason is because the other approach is much worse: if someone logs into WeScheme, and logs out, then they are still logged into Google services, which is bad from a privacy standpoint. New behavior will now be to warn the user that they're logging out of Google as well as WeScheme (506d2a4ae876a78bfc6d080d8a973d05b1e4a461, 508f05eb9f0c756c7e4430b4e1c5eaf03344f158)

Waiting to hear from SK and Emmanuel before I close this.

dyoo commented 12 years ago

Closing.